Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase_android] Migrate to Google Play Billing Library 4.0.0#5287

Closed
abyesilyurt wants to merge 3 commits intoflutter:mainfrom
abyesilyurt:migrate_billing
Closed

[in_app_purchase_android] Migrate to Google Play Billing Library 4.0.0#5287
abyesilyurt wants to merge 3 commits intoflutter:mainfrom
abyesilyurt:migrate_billing

Conversation

@abyesilyurt
Copy link

@abyesilyurt abyesilyurt commented Apr 16, 2022 •
edited
Loading

This PR migrates billing API version from 3.0.2 to 4.0.0

Fixes flutter/flutter#88664

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 16, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@abyesilyurt abyesilyurt marked this pull request as draft April 16, 2022 23:00
abyesilyurt
abyesilyurt commented Apr 16, 2022
View reviewed changes
...se_android/android/src/test/java/io/flutter/plugins/inapppurchase/MethodCallHandlerTest.java
Comment on lines -454 to -457
assertEquals(params.getSku(), skuId);
assertEquals(params.getOldSku(), oldSkuId);
assertEquals(params.getOldSkuPurchaseToken(), purchaseToken);
assertEquals(params.getReplaceSkusProrationMode(), prorationMode);
Copy link
Author

@abyesilyurt abyesilyurt Apr 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods are unavailable in Billing Client 4.0, I am looking for alternatives to test them.

@abyesilyurt abyesilyurt changed the title [in_app_purchase_android] Migrate to Google Play Billing Library 4.0.0 [in_app_purchase_android] Migrate to Billing Client 4.0.0 Apr 17, 2022
@abyesilyurt abyesilyurt changed the title [in_app_purchase_android] Migrate to Billing Client 4.0.0 [in_app_purchase_android] Migrate to Google Play Billing Library 4.0.0 Apr 17, 2022
@blasten
Copy link

blasten commented Jun 8, 2022

Thanks for the contribution. There’s a PR in progress for this #5405 cc @GaryQian

@blasten blasten closed this Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gmackall gmackall Awaiting requested review from gmackall gmackall will be requested when the pull request is marked ready for review gmackall is a code owner

Assignees

No one assigned

Labels

needs tests p: in_app_purchase platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[in_app_purchase] Migrate to Google Play Billing Library 4.0

2 participants

@abyesilyurt @blasten